Yair Zaslavsky has posted comments on this change.
Change subject: findbugs: adding category ignore list
......................................................................
Patch Set 2: (1 inline comment)
Good to see you managed to use more than one file in <excludeFilterFile>
I still have a question about the very basic implementation and why it is done
this way (I thought we would always want to run findbugs from root pom in
jenkins, so is it worth to run it without the "general" part?)
....................................................
File backend/manager/modules/bll/pom.xml
Line 249: <version>${findbugs.version}</version>
Line 250: <configuration>
Line 251: <xmlOutput>true</xmlOutput>
Line 252: <!-- Optional directory to put findbugs xdoc
xml report -->
Line 253: <excludeFilterFile>
${basedir}/exclude-filters.xml,
${basedir}/../../../../exclude-filters-general.xml</excludeFilterFile>
I see you did manage to solve using more than one file.
Can you please elaborate why in this case you need to modifiy all poms, and not
sure I fully understand why not always use the two files?
What i mean is that you will run mvn findbugs:findbugs , and for some projects
you will not have the mojo findbugs plugin definition - that's fine, for those
you have, run the two files, both the ${basedir}/exclude-filters.xml and the
exclude-filters-general.xml
Line 254:
<xmlOutputDirectory>target/site</xmlOutputDirectory>
Line 255: </configuration>
Line 256: </plugin>
Line 257: </plugins>
--
To view, visit http://gerrit.ovirt.org/15775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfbc37df07eff4c212cc5210965cabd79a51df36
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
