Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: Corrected service sync job event log msg
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java
Line 218:                                     {
Line 219:                                         
put(GlusterConstants.SERVICE_NAME, fetchedService.getServiceName());
Line 220:                                         
put(GlusterConstants.OLD_STATUS,
Line 221:                                                 
AuditLogDirector.getMessage(AuditLogType.valueOf("GLUSTER_SERVICE_STATUS_"
Line 222:                                                         + 
oldStatus.name())));
Yes, I will try to use GlusterServiceStatus enum for status messages.
Line 223:                                         
put(GlusterConstants.NEW_STATUS,
Line 224:                                                 
AuditLogDirector.getMessage(AuditLogType.valueOf("GLUSTER_SERVICE_STATUS_"
Line 225:                                                         + 
newStatus.name())));
Line 226:                                     }


-- 
To view, visit http://gerrit.ovirt.org/15549
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb29a7085f19f7e7fcb05354adae88c17b9727a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to