Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
Line 52: log.infoFormat("regex pattern for ISOs: [{0}]",
info.pattern);
Line 53: List<String> listOfIsoFiles =
getListOfIsoFiles(directory, info);
Line 54: log.infoFormat("List of ISOs: {0}", listOfIsoFiles);
Line 55:
Line 56: if ((listOfIsoFiles != null) &&
(!listOfIsoFiles.isEmpty())) {
What I do not understand why it is not like:
for (OVirtNodeInfo info : OVirtNodeInfo.get()) {
if (info.base.isDirectory()) {
for (File file : info.base.listFiles()) {
Matcher matcher = info.pattern.matcher(file);
if (matcher.find()) {
String version = matcher.group(0);
File versionFile = new File(info.base,
String.format("version-%s", version);
if (versionFile.exists()) {
do whatever we need, we have both iso and version that
matches expectations. first check if version is >=minimum then continue
}
}
}
}
}
Line 57: File[] ovirtVersionFiles =
filterOvirtFiles(directory, isoVersionPattern);
Line 58:
Line 59: for (File versionFile : ovirtVersionFiles) {
Line 60: try {
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Michael Burns <mbu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
