Kanagaraj M has posted comments on this change.
Change subject: gluster: Correct swift status display for UNKNOWN
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java
Line 67: log.debugFormat("Syncing gluster related services
for cluster {0}", cluster.getname());
Line 68: List<Callable<Map<String, GlusterServiceStatus>>>
taskList = createTaskList(upServers);
Line 69: if (taskList != null && taskList.size() > 0) {
Line 70: refreshClusterServices(cluster,
ThreadPoolUtil.invokeAll(createTaskList(upServers)));
Line 71: }
if all the servers of the cluster is gone down, here the cluster level status
won't get updated.
Line 72: } catch (Exception e) {
Line 73: log.errorFormat("Error while refreshing service
statuses of cluster {0}!",
Line 74: cluster.getname(),
Line 75: e);
Line 218: try {
Line 219: Map<Guid, GlusterServerService> existingServicesMap =
getExistingServicesMap(server);
Line 220: List<GlusterServerService> servicesToUpdate = new
ArrayList<GlusterServerService>();
Line 221:
Line 222: VDSReturnValue returnValue =
runVdsCommand(VDSCommandType.GlusterServicesList,
how about handling both up and down servers here instead handling them
separately?
Line 223: new
GlusterServicesListVDSParameters(server.getId(), getServiceNameMap().keySet()));
Line 224:
Line 225: if (!returnValue.getSucceeded()) {
Line 226: log.errorFormat("Couldn't fetch services statuses
from server {0}, error: {1}! " +
--
To view, visit http://gerrit.ovirt.org/15904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1659425e94b562916162dcddc09a19ed60b2ccf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
