Michael Pasternak has posted comments on this change.
Change subject: restapi: add Force parameter to GET .../hosts/{host:id}
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
well done alona,
few tiny comments inline
thanks.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
Line 59:
Line 60: private static final String DEFAULT_ISCSI_PORT = "3260";
Line 61: private static final String FORCE_CONSTRAINT = "force";
Line 62: private static final String FALSE = "false";
Line 63: private static final String TRUE = "true";
please move this constraint to the BaseBackendResource (may be reused by others
in the feuture)
Line 64:
Line 65: private BackendHostsResource parent;
Line 66:
Line 67: public BackendHostResource(String id, BackendHostsResource parent)
{
Line 366: public BackendHostHooksResource getHooksResource() {
Line 367: return inject(new BackendHostHooksResource(id));
Line 368: }
Line 369:
Line 370: protected boolean isForce() {
makes sense adapting to generic boolean constraint lookup and reuse
BaseBackendResource.isFiltered() instead of replicating same logic per
constraint
e.g BaseBackendResource.isFiltered() =>
BaseBackendResource.hasConstraint(CONSTRAINT)
Line 371: String value = QueryHelper.getMatrixConstraint(getUriInfo(),
FORCE_CONSTRAINT);
Line 372: if (value == null) {
Line 373: return false; // matrix param does not exist in URL, go
with the default value, which is 'false'.
Line 374: } else {
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java
Line 64: private static final String ISCSI_USER_NAME = "ori";
Line 65: private static final String ISCSI_PORT_STRING = "3260";
Line 66: private static final String ISCSI_IQN =
"iqn.1986-03.com.sun:02:ori01";
Line 67: private static final String ISCSI_SERVER_ADDRESS =
"shual1.eng.lab";
Line 68: private static final String FORCE_CONSTRAINT = "force";
i guess you could use same constraint from the BaseBackendResource, e.g
BaseBackendResource.FORCE_CONSTRAINT
Line 69:
Line 70: public BackendHostResourceTest() {
Line 71: super(new BackendHostResource(GUIDS[0].toString(), new
BackendHostsResource()));
Line 72: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
Line 32: protected static final HostStatus[] HOST_STATUS = { HostStatus.UP,
HostStatus.DOWN,
Line 33: HostStatus.UP };
Line 34: protected static final String ROOT_PASSWORD = "s3CR3t";
Line 35: protected static final String[] PARAMS =
{"00000000-0000-0000-0000-000000000000"};
Line 36: private static final String FORCE_CONSTRAINT = "force";
same, pls reuse the original one
Line 37:
Line 38: public BackendHostsResourceTest() {
Line 39: super(new BackendHostsResource(), SearchType.VDS, "Hosts : ");
Line 40: }
--
To view, visit http://gerrit.ovirt.org/15688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57ad42614de63d2a4690b22445db05d75fab4185
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
