Ravi Nori has posted comments on this change. Change subject: 7. core : Change AddVmTemplateCommand ......................................................................
Patch Set 16: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 113: private static final Guid[] EMPTY_GUID_ARRAY = new Guid[0]; Line 114: private static final String BACKEND_COMMAND_OBJECTS_HANDLER_JNDI_NAME = Line 115: "java:global/engine/bll/Backend!org.ovirt.engine.core.bll.interfaces.BackendCommandObjectsHandler"; Line 116: protected Map<Guid, CommandBase<?>> commandsMap = new HashMap<>(); Line 117: protected Map<Guid, CommandBase<?>> commandsInfoMap = new HashMap<>(); Moving the declaration of the map to previous patch and making it private Line 118: private T _parameters; Line 119: private VdcReturnValueBase _returnValue; Line 120: private CommandActionState _actionState = CommandActionState.EXECUTE; Line 121: private VdcActionType actionType; -- To view, visit http://gerrit.ovirt.org/15562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d61e6b2a0f7967bcee463ff2384cb6daba892b9 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
