Ravi Nori has posted comments on this change.

Change subject: 12. core: SPMAsyncTask - change from associatedEntities + 
single type to map
......................................................................


Patch Set 16: (2 inline comments)

....................................................
File backend/manager/dbscripts/async_tasks_sp.sql
Line 177: 
Line 178: Create or replace FUNCTION GetAsyncTasksByEntityId(v_entity_id UUID) 
RETURNS SETOF async_tasks
Line 179:    AS $procedure$
Line 180: BEGIN
Line 181:    RETURN QUERY SELECT async_tasks.*
Moving this change to patch where the FUNCTION was added
Line 182:    FROM async_tasks JOIN async_tasks_entities ON async_task_id = 
task_id
Line 183:    WHERE entity_id = v_entity_id;
Line 184: 
Line 185: END; $procedure$


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java
Line 72:     }
Line 73: 
Line 74:     private static AsyncTaskDAO getAsyncTaskDao() {
Line 75:         return DbFacade.getInstance()
Line 76:                 .getAsyncTaskDao();
Fixed
Line 77:     }
Line 78: 
Line 79:     private static final Log log = 
LogFactory.getLog(AsyncTaskUtils.class);
Line 80: 


-- 
To view, visit http://gerrit.ovirt.org/15567
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8826761f833944e8a4d9159bf91863381cfb1f79
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to