Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Add gwtdraft profile ......................................................................
Patch Set 2: (1 inline comment) .................................................... File frontend/webadmin/modules/pom.xml Line 193: <plugin> Line 194: <groupId>org.codehaus.mojo</groupId> Line 195: <artifactId>gwt-maven-plugin</artifactId> Line 196: <configuration> Line 197: <style>DETAILED</style> Good question, according to [http://css.dzone.com/news/understanding-gwt-compiler] the only real difference between DETAILED and PRETTY is that DETAILED preserves fully qualified class names, which can be useful to track down source Java code. After all, the main purpose of "gwtdraft" profile is to allow easy profiling of resulting JavaScript application in given browser. So I guess compile time difference between DETAILED and PRETTY is neglectable, especially since draftCompile=true speeds up GWT compilation a whole lot :-) Line 198: <draftCompile>true</draftCompile> Line 199: </configuration> Line 200: </plugin> Line 201: </plugins> -- To view, visit http://gerrit.ovirt.org/15849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I447becb89a29f7c231007e33e1c5003829198ccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
