Roy Golan has posted comments on this change. Change subject: core: Add Image and Instance type interfaces ......................................................................
Patch Set 17: (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageType.java Line 1: package org.ovirt.engine.core.common.businessentities; Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: Line 5: public interface ImageType extends BusinessEntity<Guid>, Nameable { this class isn't formatted. need spaces between declarations. Line 6: Line 7: void setName(String value); Line 8: Line 9: String getDescription(); .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java Line 14: * Smart card, Payload, Balloon, Sound card Line 15: * Line 16: */ Line 17: public interface InstanceType extends BusinessEntity<Guid>, Nameable { Line 18: same Line 19: void setName(String value); Line 20: Line 21: String getDescription(); Line 22: void setDescription(String value); -- To view, visit http://gerrit.ovirt.org/12279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4ef6393038588383a6f110d9743e4412ee97f75 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches