Omer Frenkel has posted comments on this change. Change subject: core: Add new NonOperational reason for cluster emulation mode ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java Line 720: Line 721: IMPORTEXPORT_IMPORT_VM_INVALID_INTERFACES(9600, AuditLogTimeInterval.MINUTE.getValue()), Line 722: VDS_SET_NON_OPERATIONAL_VM_NETWORK_IS_BRIDGELESS(9601, AuditLogTimeInterval.MINUTE.getValue()), Line 723: Line 724: EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER(9603, AuditLogTimeInterval.SECOND.getValue()), this values (9603) already exists (below) Line 725: Line 726: /** Line 727: * A highly available virtual machine went down. Line 728: */ Line 744: EXTERNAL_EVENT_ERROR(9803), Line 745: EXTERNAL_ALERT(9804), Line 746: Line 747: //watchdog Line 748: WATCHDOG_EVENT(9901); please undo this change Line 749: Line 750: private int intValue; Line 751: // indicates time interval in seconds on which identical events from same instance are supressed. Line 752: private int duplicateEventsIntervalValue; .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java Line 14: KVM_NOT_RUNNING(6), Line 15: TIMEOUT_RECOVERING_FROM_CRASH(7), Line 16: VM_NETWORK_IS_BRIDGELESS(8), Line 17: GLUSTER_COMMAND_FAILED(9), Line 18: EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER(10); i think it was decided to leave the ';' in a new line to minimize noise or something like that Line 19: Line 20: private final int value; Line 21: Line 22: private static final Map<Integer, NonOperationalReason> valueMap = new HashMap<Integer, NonOperationalReason>( -- To view, visit http://gerrit.ovirt.org/15866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20ab70f57fed145fc98f69b687358ce7b68c4435 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
