Omer Frenkel has posted comments on this change.
Change subject: core: organize AddVmCommand#canDoAction
......................................................................
Patch Set 1: (1 inline comment)
excellent, suggestion inside
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 329: return false;
Line 330: }
Line 331:
Line 332: // check cpuPinning if the check haven't failed yet
Line 333: VM vmFromParams = getParameters().getVm();
i could be nice if this parameter was defined in the beginning of the method
and used everywhere instead of getParameters().getVm() (could be in another
patch, but you already making some sense in this method so..)
Line 334: if (!isCpuPinningValid(vmFromParams.getCpuPinning(),
vmFromParams.getStaticData())) {
Line 335: return false;
Line 336: }
Line 337:
--
To view, visit http://gerrit.ovirt.org/15841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eda8868b50fd4a99462c0a649bba58e52f9bc0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
