Daniel Erez has posted comments on this change.

Change subject: webadmin: introducing virtio-scsi support
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 754: SHAREABLE_DISK_IS_NOT_SUPPORTED_FOR_DISK=Cannot ${action} ${type}. 
Disk cannot be shareable if it depends on a snapshot. In order to share it, 
remove the disk's snapshots.
Line 755: SHAREABLE_DISK_IS_NOT_SUPPORTED_BY_VOLUME_FORMAT=Cannot ${action} 
${type}. Disk's volume format is not supported for shareable disk.
Line 756: ERROR_CANNOT_DETACH_DISK_WITH_SNAPSHOT=Cannot ${action} ${type}. The 
disk is already configured in a snapshot. In order to detach it, remove the 
disk's snapshots.
Line 757: DISK_IS_ALREADY_SHARED_BETWEEN_VMS=Cannot ${action} ${type}. Disk is 
shared between vms and cannot become unshareable . Detach the disk from the 
rest of the vms it is attached to and then update the disk to be unshareable.
Line 758: SCSI_GENERIC_IO_IS_NOT_SUPPORTED_FOR_IMAGE_DISK="Cannot ${action} 
${type}. SCSI Generic IO is not supported for image disk."
Hmm, probably not here.. this error message is relevant merely for a wrong use 
case. I.e. using the sgio option not with lun disk (can be done only from the 
rest-api; it's simply not available in the UI).
Line 759: VIRTIO_SCSI_INTERFACE_IS_NOT_AVAILABLE_FOR_CLUSTER_LEVEL=Virtio-SCSI 
interface is only available on cluster level 3.3 or higher.
Line 760: 
Line 761: #Suspected (not in use?)
Line 762: USER_PASSWORD_EXPIRED=Cannot Login. User Password has expired, Please 
change your password.


-- 
To view, visit http://gerrit.ovirt.org/14908
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5b3926650586783388bf36fae399e76999843dd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to