Emily Zhang has posted comments on this change.
Change subject: engine:Trusted Compute Pools - Open Attestation integration
with oVirt engine proposal
......................................................................
Patch Set 10: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java
Line 62: valueList = AttestationService.getInstance().attestHosts(
Line 63: curVdsNames);
Line 64: addToAttestationMap(valueList);
Line 65: i++;
Line 66: }
ofri, based on previous discussion from Doron, we adopt the ideas of a
configurable 2-stage aggregated attestation; a shorter query and a longer
query. This loop is used to divide the list into at most two small lists. The
size of the first list is limited to not more than attestationFirstStageSize.
If hosts size is more than the limited size, we need the second attestation. So
'i' param means which stage, and 'secondStageFlag' means whether the second
stage attestation is needed. I have renamed these params in the patchset 12.
Line 67: }
Line 68:
Line 69: public void initVds() {
Line 70: for (VDS vds : vdss) {
Line 65: i++;
Line 66: }
Line 67: }
Line 68:
Line 69: public void initVds() {
Done
Line 70: for (VDS vds : vdss) {
Line 71: vds.setStatus(VDSStatus.NonOperational);
Line 72:
vds.setNonOperationalReason(NonOperationalReason.UNINITIALIZED);
Line 73: }
Line 65: i++;
Line 66: }
Line 67: }
Line 68:
Line 69: public void initVds() {
good suggestion, have done in patchset 12.
Line 70: for (VDS vds : vdss) {
Line 71: vds.setStatus(VDSStatus.NonOperational);
Line 72:
vds.setNonOperationalReason(NonOperationalReason.UNINITIALIZED);
Line 73: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java
Line 28: private static final String HEADER_VTIME = "vtime";
Line 29: private static final String CONTENT_TYPE = "application/json";
Line 30: private static final AttestationService instance = new
AttestationService();
Line 31: private static final Log log =
LogFactory.getLog(AttestationService.class);
Line 32: private final HashMap<String, AttestationResultEnum>
attestationValues = new HashMap<String, AttestationResultEnum>();
Ofri, you are correct, and have mapped from GUID-->AttestationResultEnum.
Line 33:
Line 34: public static HttpClient getClient() {
Line 35: HttpClient httpClient = new HttpClient();
Line 36: if (Config
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
Line 165: status = VDSStatus.Unassigned;
Line 166: break;
Line 167: }
Line 168: if (vds.getTrustedService()){
Line 169: status = VDSStatus.Unassigned;
Omer, actually, I agree with you. But according to previous emial from Doron,
we need change vds status as unassigned. Ofri&Doron, how do you think?
Line 170: }
Line 171: if (status != vds.getStatus()) {
Line 172: vdsManager.setStatus(status, vds);
Line 173:
vdsManager.UpdateStatisticsData(vds.getStatisticsData());
--
To view, visit http://gerrit.ovirt.org/14605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com>
Gerrit-Reviewer: Gang Wei <gang....@intel.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
