Moti Asayag has posted comments on this change.

Change subject: engine: Added device runtime custom properties
......................................................................


Patch Set 24: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 64:         return runtimeDeviceCustomProperties;
Line 65:     }
Line 66: 
Line 67:     public void setRuntimeDeviceCustomProperties(Map<VmDevice, 
Map<String, String>> runtimeCustomProperties) {
Line 68:         this.runtimeDeviceCustomProperties = runtimeCustomProperties;
please rename the argument name runtimeCustomProperties to 
runtimeDeviceCustomProperties
Line 69:     }
Line 70: 
Line 71:     public VM() {
Line 72:         this(new VmStatic(), new VmDynamic(), new VmStatistics());


-- 
To view, visit http://gerrit.ovirt.org/11031
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea0b33f9e57a35780fd71b9c3bbb77008de04087
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to