Lior Vernia has uploaded a new change for review.
Change subject: webadmin: Removed some code from SearchableListModel
......................................................................
webadmin: Removed some code from SearchableListModel
Not sure why the check for instanceof ArrayList was necessary, should
work just the same.
Change-Id: I0a1ef9bdd8b279a96c0b58a4d0d2eb0459f78490
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
1 file changed, 4 insertions(+), 26 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/15845/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
index 135d442..eee5fe4 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
@@ -651,20 +651,9 @@
if (getSelectedItems() != null)
{
- if (getSelectedItems() instanceof ArrayList)
+ for (Object item : getSelectedItems())
{
- for (Object item : getSelectedItems())
- {
- lastSelectedItems.add((IVdcQueryable) item);
- }
- }
- else
- {
- Iterator iterator = getSelectedItems().iterator();
- while (iterator.hasNext())
- {
- lastSelectedItems.add((IVdcQueryable) iterator.next());
- }
+ lastSelectedItems.add((IVdcQueryable) item);
}
}
@@ -686,20 +675,9 @@
IVdcQueryable newSelectedItem = null;
ArrayList<IVdcQueryable> newItems = new
ArrayList<IVdcQueryable>();
- if (value instanceof ArrayList)
+ for (Object item : value)
{
- for (Object item : value)
- {
- newItems.add((IVdcQueryable) item);
- }
- }
- else
- {
- Iterator iterator = value.iterator();
- while (iterator.hasNext())
- {
- newItems.add((IVdcQueryable) iterator.next());
- }
+ newItems.add((IVdcQueryable) item);
}
if (newItems != null)
--
To view, visit http://gerrit.ovirt.org/15845
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a1ef9bdd8b279a96c0b58a4d0d2eb0459f78490
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
