Alona Kaplan has posted comments on this change.

Change subject: engine: introducing GetCapabilitiesCommand
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsCapabilitiesCommand.java
Line 15: import org.ovirt.engine.core.vdsbroker.ResourceManager;
Line 16: 
Line 17: @LockIdNameAttribute
Line 18: @NonTransactiveCommandAttribute
Line 19: public class GetVdsCapabilitiesCommand<T extends VdsActionParameters> 
extends VdsCommand<T> {
Done
Line 20: 
Line 21:     public GetVdsCapabilitiesCommand(T parameters) {
Line 22:         super(parameters);
Line 23:     }


....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
Line 238:     
ACTION_TYPE_FAILED_PM_ENABLED_WITHOUT_AGENT(ErrorType.BAD_PARAMETERS),
Line 239:     
ACTION_TYPE_FAILED_PM_ENABLED_WITHOUT_AGENT_CREDENTIALS(ErrorType.BAD_PARAMETERS),
Line 240:     ACTION_TYPE_FAILED_AGENT_NOT_SUPPORTED(ErrorType.CONFLICT),
Line 241:     VDS_CANNOT_CHECK_VERSION_HOST_NON_RESPONSIVE(ErrorType.CONFLICT),
Line 242: 
Done
Line 243:     // VDS_CANNOT_RUN_VM_FAILED_TO_RUN, // EINAV: not in use
Line 244:     // internal const string 
VDS_CANNOT_REMOVE_VDS_DETECTED_RUNNING_VM =
Line 245:     /**
Line 246:      * "Cannot delete the server, there are desktop(s) running on the 
server.";


-- 
To view, visit http://gerrit.ovirt.org/15640
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba25577a7b66f3acedc3b32b258560861d19c621
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to