Alissa Bonas has posted comments on this change. Change subject: core: add validation non empty connection field ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 590: STORAGE_OPERATION_FAILED_SPM_NETWORK_PROBLEMS=Storage related operations can't be performed while the Storage Pool Manager is down.\nPlease make sure the Storage Pool Manager is up and running, and check network connectivity. Line 591: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please use [IP:/path or FQDN:/path] convention. Line 592: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE=VFS type cannot be empty. Line 593: VALIDATION_STORAGE_CONNECTION_EMPTY_IQN=Target details are empty. Line 594: VALIDATION_STORAGE_CONNECTION_EMPTY_CONNECTION=${fieldName} field is empty. Done Line 595: VALIDATION.TAGS.INVALID_TAG_NAME=Invalid tag name. Only alphanumeric chars, '-' and '_' characters are valid Line 596: VALIDATION.VM_POOLS.NAME.NOT_NULL=Pool name is required Line 597: VALIDATION.ROLES.NAME.NOT_NULL=Role name is required Line 598: VALIDATION.ROLES.NAME.MAX=Role name must not exceed 126 characters -- To view, visit http://gerrit.ovirt.org/15560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d9d133faa54e74a9c4c14a93edb6bd16a9ee796 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches