David Caro has posted comments on this change.
Change subject: Hook to check that the Bug-Url was specified
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File hooks/bz/patchset-created.bz.1.bug_url
Line 22: conf.load
Line 23:
Line 24: message=""
Line 25: ## Check if we have to manage that branch
Line 26: if ! vindex=$(tools.is_in "$branch" "${BRANCHES[@]}"); then
In bash the assignments do not change the return code, you can try it yourself:
$ a="$(ls doesnotexist)"
ls: cannot access doesnotexist: No such file or directory
$ echo $?
2
Line 27: echo "Ignoring branch $branch"
Line 28: exit 2
Line 29: fi
Line 30: bug_ids=($(bz.get_bug_id $commit))
Line 28: exit 2
Line 29: fi
Line 30: bug_ids=($(bz.get_bug_id $commit))
Line 31: ## break the chain if no bug-url found
Line 32: if [[ "$bug_ids" == "" ]]; then
Done
Line 33: exit 2
Line 34: fi
Line 35: bz_password="${BZ_PASS?No BZ_PASS in the config}"
Line 36: bz_user="${BZ_USER?No BZ_USER in the config}"
Line 44: failed="true"
Line 45: continue
Line 46: fi
Line 47: product="$(bz.get_product "$bug_id")"
Line 48: if ! [[ "$product" =~ ^ovirt.* ]]; then
Done
Line 49: echo "$bug_id:: Ignoring, belongs to product $product"
Line 50: message+="* Bug-Url::$bug_id::Ignored, product $product"
Line 51: fi
Line 52: done
--
To view, visit http://gerrit.ovirt.org/15571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia127c6a3d1400fb7c1646990d844b607604d3e60
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
