Liron Ar has uploaded a new change for review.
Change subject: core: avoid unneeded lock when moving disk
......................................................................
core: avoid unneeded lock when moving disk
When moving a disk, as the copy operation ends the engine attempts to
delete the source/target images (depends on whether the copy operation
has failed or succeeded) - while performing the move operation the disk
shouldn't be locked as it's already locked.
Change-Id: I0fed4563bdb0c245f485e64bcad61f8980e17ebe
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/15814/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java
index 7e07da8..79edc67 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java
@@ -24,6 +24,7 @@
removeImageParams.setStorageDomainId(storageDomainId);
removeImageParams.setParentCommand(VdcActionType.RemoveImage);
removeImageParams.setDbOperationScope(ImageDbOperationScope.NONE);
+ removeImageParams.setShouldLockImage(false);
//TODO: should be removed as async task manager issues would be
resolved, done in order
// to avoid operations on the image to wait for this remove operation
as currently async
// task manager calls the end methods of command based on the entity
id.
--
To view, visit http://gerrit.ovirt.org/15814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fed4563bdb0c245f485e64bcad61f8980e17ebe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
