Alona Kaplan has posted comments on this change.
Change subject: webadmin: Refactored code concerning Network creation
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
I think that the initializing the dc is very different for each use of the
network model. Therefore it shouldn't be part of the NetworkModel.
In this patch you missied Dc/ClusterListModel which use NetworkModel as well
(and don't need backend query to init the dc).
Also there was functionality (NetworkListModel) to avoid backend query by
getting the dc from the tree context.
Why did you remove this functionality?
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
Line 89: private void initDcList() {
Line 90: startProgress(null);
Line 91:
Line 92: // Get all data centers
Line 93: AsyncDataProvider.getDataCenterList(new
AsyncQuery(sourceListModel, new INewAsyncCallback() {
This query is redundant for DataCenter/Cluster->Logical Network- new and edit
Line 94:
Line 95: @Override
Line 96: public void onSuccess(Object model, Object returnValue) {
Line 97: ArrayList<StoragePool> dataCenters =
(ArrayList<StoragePool>) returnValue;
--
To view, visit http://gerrit.ovirt.org/15030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I624ab3a11045264dc4584b4426111c425c30c143
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
