Roy Golan has posted comments on this change. Change subject: core: Use OS repository instead of VmOsType ......................................................................
Patch Set 18: backnd * rename getOs methods to getOsId otherwise vmhandler won't work * inti search deps once instead of over and over again * use osRepository with the Injector as a field. easy for mocking * change static method to interface method osNameUpperCasedAndUnderscored * rename the injector as it is not for backend search only * made the injector thread-safe frontend * craete a uioverrides version of the injector as it doesn't support ConcurrentHashMap * adress Tomas comments about import/export and @Ignore -- To view, visit http://gerrit.ovirt.org/15078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I168225f20d567910cba861be75be87136926589f Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
