Alona Kaplan has posted comments on this change.
Change subject: webadmin: Discover Network
......................................................................
Patch Set 19: Looks good to me, approved
(2 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-01-17 11:24:39 +0200
Line 4: Commit: Lior Vernia <lver...@redhat.com>
Line 5: CommitDate: 2013-06-13 16:55:37 +0300
Line 6:
Line 7: webadmin: Discover Network
Description?
Line 8:
Line 9: Change-Id: Ic4f9e158168066e12e5cc9cc8c8f585c97fc1de8
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderNetworkListModel.java
Line 78: super.syncSearch(VdcQueryType.GetAllNetworksForProvider, new
IdQueryParameters(provider.getId()));
Line 79: }
Line 80:
Line 81: private void discover() {
Line 82: if (getWindow() != null) {
This logic should reside in DiscoverNetworkModel. Hope it was fixed in the next
patches...
Line 83: return;
Line 84: }
Line 85:
Line 86: final DiscoverNetworksModel model = new
DiscoverNetworksModel();
--
To view, visit http://gerrit.ovirt.org/11124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f9e158168066e12e5cc9cc8c8f585c97fc1de8
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
