Allon Mureinik has posted comments on this change.
Change subject: core: Add snapshot validation for empty guid.
......................................................................
Patch Set 1: No score
(3 inline comments)
Removing my -1 as per the inline discussion.
We are however missing a CDA in the import command - it should either be part
of this patch, or a different one in the series.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 298: }
Line 299:
Line 300: @Override
Line 301: protected boolean canDoAction() {
Line 302: if (Guid.Empty.equals(getParameters().getDstSnapshotId())) {
Agreed.
Line 303: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_CORRUPTED_VM_SNAPSHOT_ID);
Line 304: }
Line 305:
Line 306: SnapshotsValidator snapshotValidator =
createSnapshotValidator();
....................................................
Commit Message
Line 7: core: Add snapshot validation for empty guid.
Line 8:
Line 9: Currently when virt-v2v is used to convert a vm from a foreign
Line 10: hypervisor (Xen, VMware and etc), it sets the vm_snapshot_id of
Line 11: all disks of that vm to empty guid.
Please add a reference to it
Line 12: This later causes issues doing different tasks on snapshots.
Line 13:
Line 14: The proposed fix is to add a validation whether the
Line 15: snapshot id is empty and provides an appropriate message.
Line 11: all disks of that vm to empty guid.
Line 12: This later causes issues doing different tasks on snapshots.
Line 13:
Line 14: The proposed fix is to add a validation whether the
Line 15: snapshot id is empty and provides an appropriate message.
fair enough.
But at the very least, we need a CDA to block such import attempts
Line 16:
Line 17: Change-Id: I19bc2982adecca198f8dc38ca011f4528dd58db9
--
To view, visit http://gerrit.ovirt.org/15701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19bc2982adecca198f8dc38ca011f4528dd58db9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
