Yair Zaslavsky has posted comments on this change.
Change subject: 13. core: Introducing "end command coordination" by command Id
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
Line 23: /**
Line 24: * Base class for all tasks regarding a specific command.
Line 25: */
Line 26: public class EntityAsyncTask extends SPMAsyncTask {
Line 27: private static final Object _lockObject = new Object();
You're not missing anything :)
Rome was not built in a day, and this is NOT the final say around this class.
I first wanted to change the functionality of end of command coordination, and
I definitely plan to improve concurrency issues here and in AsyncTaskMgr (for
example, move to RWLock where possible instead of synchronized, and yes, also
change the map).
Line 28:
Line 29: private static final Map<Guid, EntityMultiAsyncTasks>
_multiTasksByCommandIds =
Line 30: new HashMap<Guid, EntityMultiAsyncTasks>();
Line 31:
--
To view, visit http://gerrit.ovirt.org/15569
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53999748c791aae04287efaa01c10ea7037e5ff2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
