Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added Provider/Networks subtab
......................................................................
Patch Set 6: Looks good to me, approved
(2 inline comments)
....................................................
Commit Message
Line 4: Commit: Lior Vernia <lver...@redhat.com>
Line 5: CommitDate: 2013-06-13 16:55:37 +0300
Line 6:
Line 7: webadmin: Added Provider/Networks subtab
Line 8:
What about a description?
Line 9: Change-Id: I5806572ec4ac0c7b892dfa8ef714d8f93a8459a7
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ProviderModule.java
Line 101: if (lastExecutedCommand ==
getModel().getRemoveCommand()) {
Line 102: return removeConfirmPopupProvider.get();
Line 103: } else {
Line 104: return super.getConfirmModelPopup(source,
lastExecutedCommand);
Line 105: }
Please fix indentation.
Line 106: }
Line 107: };
Line 108: }
Line 109:
--
To view, visit http://gerrit.ovirt.org/15028
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5806572ec4ac0c7b892dfa8ef714d8f93a8459a7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
