Allon Mureinik has posted comments on this change.
Change subject: 1. core : Distingushing between entity and vdsm task ids
......................................................................
Patch Set 26: (4 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_03_0210_add_vdsm_task_id_and_index_to_async_tasks.sql
Line 1: select fn_db_add_column('async_tasks', 'vdsm_task_id', 'UUID DEFAULT
NULL');
Looking forward, we'd like to support tasks from other providers, not only vdsm.
Perhaps calling this column "external_task_id" would be a good idea.
Line 1: select fn_db_add_column('async_tasks', 'vdsm_task_id', 'UUID DEFAULT
NULL');
Line 2: CREATE INDEX IDX_vdsm_task_id ON async_tasks(vdsm_task_id);
Most of the entities in the engine are long-lived, and are removed only by a
conscientious decision of the administrator.
Tasks are different - they are created and deleted without the admin knowing
about them, and sooner or later, this index will become fragmented.
This is probably not in the scope of /this/ patch, but IMHO, we need a periodic
rebuild mechanism here.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
Line 382: public static final Guid GLUSTER_SERVER_UUID2 = new
Guid("da9e2f09-2835-4530-9bf5-576c52b11942");
Line 383:
Line 384: public static final Guid GLUSTER_SERVER_UUID_NEW = new
Guid("da9e2f09-2835-4530-9bf5-576c52b11943");
Line 385:
Line 386: protected static final Guid EXISTING_VDSM_TASK_ID = new
Guid("140fd52b-3400-4cdd-8d3f-C9d03704b0aa");
why not public?
Line 387:
Line 388: /**
Line 389: * A test provider that exists.
Line 390: */
....................................................
Commit Message
Line 18: One of the issues that will be handled in future patches is not to
include
Line 19: the VDSM task ID at the insert_AsyncTasks stored procedure, but at
this point
Line 20: this is not addressed (as this will be a part of a patch handling
splitting the
Line 21: insert of task from getting vdsm task id + updating in db)
Line 22:
Please add a link to the feature page
Line 23: Change-Id: I75e35773b18e342dbe61242829ce989b1f51ee70
--
To view, visit http://gerrit.ovirt.org/14075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75e35773b18e342dbe61242829ce989b1f51ee70
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
