Daniel Erez has posted comments on this change.
Change subject: Expose the info about HBA devices in frontend
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java
Line 162: List<EnumMap<HbaDeviceKeys, String>> hbaDevices = new
ArrayList<EnumMap<HbaDeviceKeys, String>>();
Line 163: List<Map<String, String>> fcDevices =
vds.getHBAs().get("FC"); //$NON-NLS-1$
Line 164:
Line 165: if (fcDevices != null) {
Line 166: for (Map<String, String> device: fcDevices) {
I would still prefer an object as we display a specific well-known set of
attributes. But, if others agree, I guess it's fine this way (as it's
simpler...)
Line 167: EnumMap<HbaDeviceKeys, String> deviceModel = new
EnumMap<HbaDeviceKeys, String>(HbaDeviceKeys.class);
Line 168: deviceModel.put(HbaDeviceKeys.MODEL_NAME,
device.get("model")); //$NON-NLS-1$
Line 169: deviceModel.put(HbaDeviceKeys.WWNN,
device.get("wwnn")); //$NON-NLS-1$
Line 170: deviceModel.put(HbaDeviceKeys.WWNPS,
device.get("wwpn")); //$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/15091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44efcf1feabb3491aa46bd9294b14424483872c1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
