Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: build: rename xxx_DEV to DEV_xxx
......................................................................
packaging: build: rename xxx_DEV to DEV_xxx
Change-Id: I04f9947ae5ac5448aea309a1b2de2b96ee867963
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M Makefile
M README.developer
2 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/15735/1
diff --git a/Makefile b/Makefile
index d46ed65..e5a1666 100644
--- a/Makefile
+++ b/Makefile
@@ -55,10 +55,10 @@
ifeq ($(BUILD_UT),0)
BUILD_FLAGS:=$(BUILD_FLAGS) -D skipTests
endif
-EXTRA_BUILD_FLAGS_DEV=
-EXTRA_BUILD_FLAGS_DEV_GWT:=-D gwt.userAgent=gecko1_8
+DEV_EXTRA_BUILD_FLAGS=
+DEV_EXTRA_BUILD_FLAGS_GWT:=-D gwt.userAgent=gecko1_8
ifneq ($(DEV_BUILD_GWT_DRAFT),0)
-EXTRA_BUILD_FLAGS_DEV_GWT:=$(EXTRA_BUILD_FLAGS_DEV_GWT) -Dgwt.draftCompile=true
+DEV_EXTRA_BUILD_FLAGS_GWT:=$(DEV_EXTRA_BUILD_FLAGS_GWT) -Dgwt.draftCompile=true
endif
BUILD_TARGET=deploy
ENGINE_NAME=$(PACKAGE_NAME)
@@ -510,8 +510,8 @@
[ -n "$(DEBUG_MODULE)" ] || ( echo "Please specify DEBUG_MODULE" &&
false )
cd "frontend/webadmin/modules/$(DEBUG_MODULE)" && \
$(MVN) \
- $(EXTRA_BUILD_FLAGS_DEV) \
- $(EXTRA_BUILD_FLAGS_DEV_GWT) \
+ $(DEV_EXTRA_BUILD_FLAGS) \
+ $(DEV_EXTRA_BUILD_FLAGS_GWT) \
-Dgwt.noserver=true \
-Pgwtdev,gwt-admin,gwt-user \
gwt:debug
@@ -521,7 +521,7 @@
rm -f $(GENERATED)
$(MAKE) \
all \
- EXTRA_BUILD_FLAGS="$(EXTRA_BUILD_FLAGS_DEV_GWT)
$(EXTRA_BUILD_FLAGS_DEV)" \
+ EXTRA_BUILD_FLAGS="$(DEV_EXTRA_BUILD_FLAGS_GWT)
$(DEV_EXTRA_BUILD_FLAGS)" \
$(NULL)
install-dev: \
@@ -530,7 +530,7 @@
$(MAKE) \
install \
- EXTRA_BUILD_FLAGS="$(EXTRA_BUILD_FLAGS_DEV_GWT)
$(EXTRA_BUILD_FLAGS_DEV)" \
+ EXTRA_BUILD_FLAGS="$(DEV_EXTRA_BUILD_FLAGS_GWT)
$(DEV_EXTRA_BUILD_FLAGS)" \
PYTHON_DIR="$(PREFIX)$(PYTHON_SYS_DIR)" \
$(NULL)
install -d "$(DESTDIR)$(LOCALSTATE_DIR)/tmp"
diff --git a/README.developer b/README.developer
index ba05321..856a114 100644
--- a/README.developer
+++ b/README.developer
@@ -102,21 +102,21 @@
BUILD_UT [0]
Perform unit tests during build.
-EXTRA_BUILD_FLAGS_DEV
+DEV_BUILD_GWT_DRAFT [0]
+ Build draft gwt application without optimizations.
+
+DEV_EXTRA_BUILD_FLAGS
Any maven build flags requires for building.
For example, if your machine is low on memory, use:
EXTRA_BUILD_FLAGS_DEV="-Dgwt-plugin.localWorkers=2"
-EXTRA_BUILD_FLAGS_DEV_GWT [-D gwt.userAgent=gecko1_8]
+DEV_EXTRA_BUILD_FLAGS_GWT [-D gwt.userAgent=gecko1_8]
By default, only the gecko1_8 support is built, building all
permutations is possible by specifying EXTRA_BUILD_FLAGS_DEV_GWT="".
DEV_REBUILD [1]
Disable if only packaging components were modified.
-
-DEV_BUILD_GWT_DRAFT [0]
- Build draft gwt application without optimizations.
SETUP
--
To view, visit http://gerrit.ovirt.org/15735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04f9947ae5ac5448aea309a1b2de2b96ee867963
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
