Alon Bar-Lev has posted comments on this change.

Change subject: engine: change path of console descriptors
......................................................................


Patch Set 1: (1 inline comment)

Thanks!

One minor comment.

....................................................
File packaging/conf/ovirt-engine-proxy.conf.in
Line 24:     <Location /ovirt-engine/>
Line 25:         ProxyPass ajp://localhost:@JBOSS_AJP_PORT@/
Line 26:     </Location>
Line 27: 
Line 28:     <LocationMatch 
^/(UserPortal($|/)|OvirtEngineWeb($|/)|webadmin($|/)|docs($|/)|ovirt-engine-novnc($|/)|ovirt-engine-novnc-main.html$|spice/|ca.crt$|engine.ssh.key.txt$|rhevm.ssh.key.txt$|ovirt-engine-style.css$|ovirt-engine-attachment($|/))>
No need for $ as it is not going to be used asi-is, you can have 
ovirt-enigne-attachment/
Line 29:         ProxyPassMatch ajp://localhost:@JBOSS_AJP_PORT@
Line 30:         <IfModule deflate_module>
Line 31:             AddOutputFilterByType DEFLATE text/javascript text/css 
text/html text/xml text/json application/xml application/json application/x-yaml
Line 32:         </IfModule>


-- 
To view, visit http://gerrit.ovirt.org/15727
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35c02a8edb1dd638d4062e4e33854b4df139547
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to