Alon Bar-Lev has uploaded a new change for review.
Change subject: build: enhance gwt-debug target
......................................................................
build: enhance gwt-debug target
1. add dev build flags to maven execution.
2. set default application port to 8080.
Change-Id: I3b2d466b0bef36483f4a688f98eb603d67b2dc8e
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
Reported-By: Daniel Erez <de...@redhat.com>
---
M Makefile
M frontend/webadmin/modules/pom.xml
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/15723/1
diff --git a/Makefile b/Makefile
index 76e7bb6..3e82405 100644
--- a/Makefile
+++ b/Makefile
@@ -502,7 +502,13 @@
gwt-debug:
[ -n "$(DEBUG_MODULE)" ] || ( echo "Please specify DEBUG_MODULE" &&
false )
- cd "frontend/webadmin/modules/$(DEBUG_MODULE)" && $(MVN) gwt:debug
-Pgwtdev,gwt-admin,gwt-user -Dgwt.noserver=true
+ cd "frontend/webadmin/modules/$(DEBUG_MODULE)" && \
+ $(MVN) \
+ $(EXTRA_BUILD_FLAGS_DEV) \
+ $(EXTRA_BUILD_FLAGS_DEV_GWT) \
+ -Dgwt.noserver=true \
+ -Pgwtdev,gwt-admin,gwt-user \
+ gwt:debug
install-dev:
[ "$(DEV_REBUILD)" != 0 ] && rm -f "$(BUILD_FILE)" || :
diff --git a/frontend/webadmin/modules/pom.xml
b/frontend/webadmin/modules/pom.xml
index 7a89a04..ba7a579 100644
--- a/frontend/webadmin/modules/pom.xml
+++ b/frontend/webadmin/modules/pom.xml
@@ -50,6 +50,8 @@
<!-- Control target locales for GWT compilation, maps to 'locale' deferred
binding property in *.gwt.xml -->
<!-- By default, only English locale is supported, see 'all-langs' profile
for a complete list -->
<gwt.locale>en_US</gwt.locale>
+ <!-- By default, engine port is 8080 -->
+ <engine.port.http>8080</engine.port.http>
</properties>
<dependencyManagement>
<dependencies>
@@ -157,7 +159,7 @@
<configuration>
<logLevel>INFO</logLevel>
<style>OBF</style>
- <port>8700</port>
+ <port>${engine.port.http}</port>
<noServer>true</noServer>
<bindAddress>0.0.0.0</bindAddress>
<gen>${gwtGenDirectory}</gen>
--
To view, visit http://gerrit.ovirt.org/15723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b2d466b0bef36483f4a688f98eb603d67b2dc8e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
