Sahina Bose has posted comments on this change.
Change subject: webadmin: fix displaying binary gluster hook
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/GlusterHookResolveConflictsModel.java
Line 265: String content = (String) returnValue;
Line 266: getContentModel().getContent().setEntity(content);
Line 267: stopProgress();
Line 268: }
Line 269: }), getGlusterHookEntiry().getId(),
selectedServer.getServerId());
minor - consider refactoring to getGlusterHookEntity()
Line 270: }
Line 271: }
Line 272:
Line 273: public boolean isAnyResolveActionSelected() {
--
To view, visit http://gerrit.ovirt.org/15704
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia189162dc339bab135979b4801c964112b24df18
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
