Allon Mureinik has uploaded a new change for review. Change subject: core: Unwrap else blcoks in Guid ......................................................................
core: Unwrap else blcoks in Guid Unwrapped a couple of else blocks where the if does not terminate normally. Change-Id: I05ae00a16ac86d93d011af0addea112a6baa63cc Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java 1 file changed, 5 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/15696/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java index f875c34..2b44745 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java @@ -58,17 +58,15 @@ public static Guid createGuidFromString(String candidate) { if (candidate == null) { return null; - } else { - return new Guid(candidate); } + return new Guid(candidate); } public static Guid createGuidFromStringDefaultEmpty(String candidate) { if (candidate == null) { return Guid.Empty; - } else { - return new Guid(candidate); } + return new Guid(candidate); } public static boolean isNullOrEmpty(Guid id) { @@ -100,10 +98,10 @@ @Override public String toString() { - if (uuid == null) + if (uuid == null) { return "[null]"; - else - return uuid.toString(); + } + return uuid.toString(); } /** -- To view, visit http://gerrit.ovirt.org/15696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I05ae00a16ac86d93d011af0addea112a6baa63cc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches