Allon Mureinik has uploaded a new change for review. Change subject: core: Remove GuidUtils.getGuidValue(Guid) ......................................................................
core: Remove GuidUtils.getGuidValue(Guid) Since the unification of Guid and NGuid, this method is meaningless. Change-Id: I9b2e64199f634f25f1d2c0c224e1a13b380ba36f Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java 2 files changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/15694/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java index 9ed31d0..84ccdba 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java @@ -59,7 +59,6 @@ import org.ovirt.engine.core.dal.dbbroker.DbFacade; import org.ovirt.engine.core.dao.VmDynamicDAO; import org.ovirt.engine.core.dao.VmStaticDAO; -import org.ovirt.engine.core.utils.GuidUtils; import org.ovirt.engine.core.utils.customprop.ValidationError; import org.ovirt.engine.core.utils.customprop.VmPropertiesUtils; import org.ovirt.engine.core.utils.customprop.VmPropertiesUtils.VMCustomProperties; @@ -732,7 +731,7 @@ if (getVmTemplate() != null && !getVmTemplate().getDiskList().isEmpty()) { for (DiskImage disk : getParameters().getDiskInfoDestinationMap().values()) { if (disk.getStorageIds() != null && !disk.getStorageIds().isEmpty()) { - permissionList.add(new PermissionSubject(GuidUtils.getGuidValue(disk.getStorageIds().get(0)), + permissionList.add(new PermissionSubject(disk.getStorageIds().get(0), VdcObjectType.Storage, ActionGroup.CREATE_DISK)); } } diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java index 70c4cc0..a31e6c0 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java @@ -54,10 +54,6 @@ } - public static Guid getGuidValue(Guid id) { - return id == null ? null : id; - } - private static final String SEPARATOR = ","; /** -- To view, visit http://gerrit.ovirt.org/15694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b2e64199f634f25f1d2c0c224e1a13b380ba36f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
