Allon Mureinik has posted comments on this change.
Change subject: engine: Save VDSM information about HBA devices
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_03_0200_add_hbas_col.sql
Line 1: select fn_db_add_column('vds_dynamic', 'hbas', 'text default null');
the default null is redundant IMHO.
Also, remember to rename the script when you rebase.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 341:
Line 342: // parse out the HBAs available in this host
Line 343: Map<String, List<Map<String, String>>> hbas = new HashMap<>();
Line 344: for (Map.Entry<String, Object[]> el: ((Map<String,
Object[]>)xmlRpcStruct.get(VdsProperties.HBAInventory)).entrySet()) {
Line 345: List<Map<String, String>> devicesList = new
ArrayList<Map<String, String>>();
You can use java 7 syntax - new ArrayList<>
Line 346:
Line 347: for (Object device: el.getValue()) {
Line 348: devicesList.add((Map<String,String>)device);
Line 349: }
--
To view, visit http://gerrit.ovirt.org/14141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8512f30c795690edc46838c0eb422013871b35f9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
