[Engine-patches] Change in ovirt-engine[master]: webadmin: reuse updateStorageDomain in StorageListModel

[abonas]

Alissa Bonas has uploaded a new change for review.

Change subject: webadmin: reuse updateStorageDomain in StorageListModel
......................................................................

webadmin: reuse updateStorageDomain in StorageListModel

Reuse updateStorageDomain code in StorageListModel by extracting it to
a separate method instead of duplicating it as it is today.

Change-Id: Ie9c28c751237876f85df360cf29dc8e1d16e4a77
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 14 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/15661/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
index 8433514..668c780 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
@@ -1234,15 +1234,19 @@
                 updatePath();
             }
             else {
-            Frontend.RunAction(VdcActionType.UpdateStorageDomain, new 
StorageDomainManagementParameter(this.storageDomain), new 
IFrontendActionAsyncCallback() {
-                @Override
-                public void executed(FrontendActionAsyncResult result) {
-                    StorageListModel storageListModel = (StorageListModel) 
result.getState();
-                    storageListModel.onFinish(storageListModel.context, true, 
storageListModel.storageModel);
-                }
-                }, this);
+                updateStorageDomain();
             }
         }
+    }
+
+    private void updateStorageDomain() {
+        Frontend.RunAction(VdcActionType.UpdateStorageDomain, new 
StorageDomainManagementParameter(this.storageDomain), new 
IFrontendActionAsyncCallback() {
+            @Override
+            public void executed(FrontendActionAsyncResult result) {
+                StorageListModel storageListModel = (StorageListModel) 
result.getState();
+                storageListModel.onFinish(storageListModel.context, true, 
storageListModel.storageModel);
+            }
+        }, this);
     }
 
     public void saveNewPosixStorage() {
@@ -1359,15 +1363,7 @@
             }), null, path);
         } else {
 
-            Frontend.RunAction(VdcActionType.UpdateStorageDomain, new 
StorageDomainManagementParameter(storageDomain), new 
IFrontendActionAsyncCallback() {
-                @Override
-                public void executed(FrontendActionAsyncResult result) {
-
-                    StorageListModel storageListModel = (StorageListModel) 
result.getState();
-                    storageListModel.onFinish(storageListModel.context, true, 
storageListModel.storageModel);
-
-                }
-            }, this);
+            updateStorageDomain();
         }
     }
 
@@ -1496,15 +1492,7 @@
                 updatePath();
             }
             else {
-               Frontend.RunAction(VdcActionType.UpdateStorageDomain, new 
StorageDomainManagementParameter(this.storageDomain),
-                new IFrontendActionAsyncCallback() {
-                    @Override
-                    public void executed(FrontendActionAsyncResult result) {
-                        StorageListModel storageListModel = (StorageListModel) 
result.getState();
-                        storageListModel.onFinish(storageListModel.context, 
true, storageListModel.storageModel);
-
-                    }
-                }, this);
+                updateStorageDomain();
             }
         }
     }
@@ -1747,16 +1735,7 @@
                 updatePath();
             }
             else {
-                Frontend.RunAction(VdcActionType.UpdateStorageDomain,
-                        new 
StorageDomainManagementParameter(this.storageDomain),
-                        new IFrontendActionAsyncCallback() {
-                            @Override
-                            public void executed(FrontendActionAsyncResult 
result) {
-                                StorageListModel storageListModel = 
(StorageListModel) result.getState();
-                                
storageListModel.onFinish(storageListModel.context, true, 
storageListModel.storageModel);
-                            }
-                        },
-                        this);
+                updateStorageDomain();
             }
         }
     }


-- 
To view, visit http://gerrit.ovirt.org/15661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9c28c751237876f85df360cf29dc8e1d16e4a77
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches