Omer Frenkel has posted comments on this change.
Change subject: backend: Make adding (virtio-)console to virtual machines
optional
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 96: if (parameters.getVmStaticData() != null) {
Line 97: setVmTemplateId(parameters.getVmStaticData().getVmtGuid());
Line 98: }
Line 99:
Line 100: if (parameters.isConsoleEnabled() == null) {
making the parameter nullable is not needed here, just make is regular boolean,
false as default.
it was needed in the audio device in order to preserve old behavior before the
parameter (for rest api)
Line 101: parameters.setConsoleEnabled(false);
Line 102: }
Line 103:
Line 104: parameters.setEntityId(getVmId());
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 104: }
Line 105:
Line 106: if (getParameters().isConsoleEnabled() == null) {
Line 107: parameters.setConsoleEnabled(false);
Line 108: }
same here
Line 109:
Line 110: }
Line 111:
Line 112: protected void updateVmDisks() {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 69: setCustomDefinedProperties(parameters.getVmStaticData());
Line 70: setCustomDefinedProperties(getVm().getStaticData());
Line 71: }
Line 72:
Line 73: if (parameters.isConsoleEnabled() == null) {
i think on update we should use null as "don't touch device setting" (if its
there leave it, if not don't create)
Line 74: parameters.setConsoleEnabled(false);
Line 75: }
Line 76: }
Line 77:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 349: }
Line 350:
Line 351: @Override
Line 352: protected void buildVmConsoleDevice() {
Line 353: buildVmDevicesFromDb(VmDeviceGeneralType.CONSOLE, false);
why not add address for this device?
Line 354: }
Line 355:
Line 356: private void buildVmDevicesFromDb(VmDeviceGeneralType
generalType, boolean addAddress) {
Line 357: List<VmDevice> vmDevices =
--
To view, visit http://gerrit.ovirt.org/15554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d913b1fca9d064424aab58d4c34ec3e4b246373
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
