Alon Bar-Lev has posted comments on this change.
Change subject: userportal,webadmin: update branding manager
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingManager.java
Line 168: private Map<String, String> getMessageMap(final String prefix,
final Locale locale) {
Line 169: List<BrandingTheme> messageThemes = getBrandingThemes();
Line 170: // We need this map to remove potential duplicate strings
from the resource bundles.
Line 171: Map<String, String> keyValues = new HashMap<String, String>();
Line 172: for (BrandingTheme theme : messageThemes) {
Have you removed my fix in purpose? surviving messageThemes == null?
Line 173: ResourceBundle messagesBundle =
theme.getMessagesBundle(locale);
Line 174: for (String key : messagesBundle.keySet()) {
Line 175: if (key.startsWith(BRAND_PREFIX + "." + prefix) ||
key.startsWith(COMMON_PREFIX)) { //$NON-NLS-1$
Line 176: // We can potentially override existing values
here
--
To view, visit http://gerrit.ovirt.org/15579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87f5a6684701c9d5f603bf79459a3a5b6614b24f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
