Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] Add internal directory provider
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/directory/internal/InternalDirectory.java
Line 14: public class InternalDirectory implements Directory {
Line 15: // This is the only user of this directory:
Line 16: private final DirectoryUser admin = new DirectoryUser(
Line 17: this,
Line 18:
Guid.createGuidFromString("fdfc627c-d875-11e0-90f0-83df133b58cc"),
What does the string represent? where did you get it from? worth extracting to
constant? I would extract to constant mentioning its the GUID in db (I guess
this is what you meant, right?)
Line 19: Config.<String> GetValue(ConfigValues.AdminUser)
Line 20: );
Line 21:
Line 22: @Override
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/directory/internal/InternalDirectoryProvider.java
Line 6: import org.ovirt.engine.core.bll.directory.DirectorySpi;
Line 7: import org.ovirt.engine.core.common.users.Directory;
Line 8:
Line 9: public class InternalDirectoryProvider implements DirectorySpi {
Line 10: // The list of directories managed by this implementation (will be
lazily
Not sure why we need to do lazy initialization here.
Line 11: // initialized later:
Line 12: private volatile List<Directory> directories;
Line 13:
Line 14: @Override
--
To view, visit http://gerrit.ovirt.org/15601
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f4e7db1b42ded74f611a9453b3db229c6d069d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
