Liron Ar has posted comments on this change. Change subject: core: add check for iqn in addStorageServerConn ......................................................................
Patch Set 5: Alissa - I agree with most of the thing you wrote, IMO the validation should be moved to a validator/helper class - whatever you chose. I think that we shouldn't add code that causes to duplication and that we will be eventually deleted - I think that adding the validation in a validator/helper class rather in the command is a required change here that will also prevent us from having problem in the future (no need to remember to fix in 2 places). Anyway, that's my suggestion (no -1), any of the maintainers can decide to accept it as it..i'd change tough. -- To view, visit http://gerrit.ovirt.org/15516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
