Michael Pasternak has posted comments on this change.
Change subject: restapi: support for creating snapshot with memory
......................................................................
Patch Set 20: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java
Line 45: CreateAllSnapshotsFromVmParameters snapshotParams =
Line 46: new CreateAllSnapshotsFromVmParameters(parentId,
snapshot.getDescription());
Line 47: if (snapshot.isSetSnapshotMemory()) {
Line 48: snapshotParams.setSaveMemory(snapshot.isSnapshotMemory());
Line 49: }
please squash this change to the http://gerrit.ovirt.org/15186
thanks
Line 50: return performCreate(VdcActionType.CreateAllSnapshotsFromVm,
Line 51: snapshotParams,
Line 52: new SnapshotIdResolver(),
Line 53: block);
--
To view, visit http://gerrit.ovirt.org/15187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd9b7501473684cd85701d2ac9aa35260b35184
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
