Yaniv Bronhaim has posted comments on this change.
Change subject: core: Add log when task could not end action.
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java
Line 68: java.util.ArrayList<EntityAsyncTask>
CurrentActionTypeTasks = GetCurrentActionTypeTasks();
Line 69:
Line 70: for (EntityAsyncTask task : CurrentActionTypeTasks) {
Line 71: if (task.getState() != AsyncTaskState.Ended) {
Line 72: log.infoFormat("Task ID: '{0}' is in state {1}.
End action for entity {2} will proceed when all the entity's tasks are
completed.",
could be: Task id {0} is in state {1}. Action on entity {2} is still running.
or the other way around:
Action on entity {2} is still running (Task id {0} is in state {1})
Line 73: task.getTaskID(),
Line 74: task.getState(),
Line 75: getContainerId());
Line 76: return false;
Line 245: synchronized (_listTasks) {
Line 246: for (EntityAsyncTask task : _listTasks.values()) {
Line 247: if (!taskWasCleared(task)) {
Line 248: log.infoFormat("[within thread]: Some of the
tasks related to entity id {0} were not cleared yet (Task id {1} is in state
{2}).",
Line 249: getContainerId(),
in my opinion, this comment is quite long:
2013-06-11 15:55:57,181 INFO [org.ovirt.engine.core.bll.EntityMultiAsyncTasks]
(pool-5-thread-40) [within thread]: Some of the tasks related to entity id
3ca689c1-70d1-485c-b519-369170e08f63 were not cleared yet (Task id
a7019ff8-3025-4
73f-8839-9c05794c26b3 is in state Polling).
within_thread is redundant thanks to (pool-5-thread-40) and the message is too
long: could be: Tasks of entity {0) are still running (task id {1}, state {2})
Line 250: task.getTaskID(),
Line 251: task.getState());
Line 252: return false;
Line 253: }
--
To view, visit http://gerrit.ovirt.org/14433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e4700676622b23c79a388b6aa3b92ae1aa15e9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
