Roy Golan has posted comments on this change.

Change subject: core: osinfo - add convenience no-version methods
......................................................................


Patch Set 3:

no the warnings are not part of it. I'm in opinion this should not be logged. I 
don't see a lot of value in logging it.

Having said that this isn't a real overhead to log it.

-- 
To view, visit http://gerrit.ovirt.org/15538
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24444fc1b9722bd2ca43a58ab251ead2afdfbbc6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to