Omer Frenkel has posted comments on this change.
Change subject: core : Distingushing between entity and vdsm task ids
......................................................................
Patch Set 22: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_03_0190_add_vdsm_task_id_to_async_tasks.sql
Line 1: select fn_db_add_column('async_tasks', 'vdsm_task_id', 'UUID DEFAULT
NULL');
dont forget to update the script name on last rebase
....................................................
File
backend/manager/dbscripts/upgrade/03_03_0200_add_index_to_vdsm_task_id_of_async_tasks.sql
Line 1: CREATE INDEX IDX_vdsm_task_id ON async_tasks(vdsm_task_id);
i think you could use the previous upgrade file to do both db operations, no?
(i don't mind too much)
--
To view, visit http://gerrit.ovirt.org/14075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75e35773b18e342dbe61242829ce989b1f51ee70
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
