Oved Ourfali has posted comments on this change.
Change subject: core, restapi, webadmin, userportal: cloud-init [3/6] - backend
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 158: if (!vmDevice.getIsManaged()) {
Line 159: continue;
Line 160: }
Line 161: // ignore additional cd devices if a payload is
present
Line 162: if (!VmPayload.isPayload(vmDevice.getSpecParams()) &&
vmDevices.size() > 1) {
Have you seen Omer's comment on that one from the previous patch set?
Line 163: continue;
Line 164: }
Line 165: struct = new HashMap<String, Object>();
Line 166: String cdPath = vm.getCdPath();
--
To view, visit http://gerrit.ovirt.org/14350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8ffa5b92ff79cdac5e401c0a815ffcf517590d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
