Ravi Nori has posted comments on this change.
Change subject: core: Fix variable names in VdcReturnValueBase
......................................................................
Patch Set 15: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java
Line 23: * that have place holders but don't have a vdsm task id.
Line 24: */
Line 25: private ArrayList<Guid> asyncTaskIdList = new ArrayList<Guid>();
Line 26: private ArrayList<Guid> vdsmTaskIdList = new ArrayList<Guid>();
Line 27: private final ArrayList<Guid> internalVdsmIdList = new
ArrayList<Guid>();
code from CommandBase
protected ArrayList<Guid> getTaskIdList() {
return getParameters().getParentCommand() != VdcActionType.Unknown
? getReturnValue().getInternalVdsmTaskIdList()
: getReturnValue().getVdsmTaskIdList();
}
Line 28: private boolean endActionTryAgain = true;
Line 29: private final ArrayList<String> executeFailedMessages = new
ArrayList<String>();
Line 30: private VdcFault fault;
Line 31: private String correlationId;
--
To view, visit http://gerrit.ovirt.org/14909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfbd19f8eeef4a9a0d30eadaacb1d833cae0ec7
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
