Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: Fix behavior unsupported locale ......................................................................
Patch Set 3: Yes, I would normally expect that to be the behavior, to fall back from more specific to less specific. However in our case we only support particular specific locales, that is why I worked it the other way. This brings up the question. What to do when the browser reports a more specific unsupported locale. For instance es_bo (spanish bolivia). Right now the code will return english, as all the close ones won't match the more specific one we are looking for. Close being (es, es_bo, es_bo_xxx) defined here [1]. I guess the question is more, if a more specific locale that doesn't match is returned, should I go up to the least specific and match that the locales 'close' to our more specific locale? [1] http://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/LocaleUtils.html#isAvailableLocale%28java.util.Locale%29 -- To view, visit http://gerrit.ovirt.org/15520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5beceaf7f4ce2333e83cd72c3fa8721103cf805 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
