Eli Mesika has posted comments on this change. Change subject: gluster: bll command to start/stop/restart service ......................................................................
Patch Set 11: (2 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_03_0200_add_gluster_service_roles.sql Line 8: v_super_user_id_0001 := '00000000-0000-0000-0000-000000000001'; Line 9: v_GLUSTER_ADMIN_ROLE_ID := 'DEF0000b-0000-0000-0000-DEF00000000b'; Line 10: Line 11: --MANIPULATE_GLUSTER_HOOK Line 12: INSERT INTO roles_groups(role_id,action_group_id) SELECT v_super_user_id_0001, 1004 I would like 1004 to be also a variable with a descriptive name , same as the IDs used above Line 13: WHERE not exists (SELECT role_id, action_group_id FROM roles_groups Line 14: WHERE role_id=v_super_user_id_0001 and action_group_id=1004); Line 15: Line 16: -- Map all manipulate gluster hook action groups to the gluster admin role Line 12: INSERT INTO roles_groups(role_id,action_group_id) SELECT v_super_user_id_0001, 1004 Line 13: WHERE not exists (SELECT role_id, action_group_id FROM roles_groups Line 14: WHERE role_id=v_super_user_id_0001 and action_group_id=1004); Line 15: Line 16: -- Map all manipulate gluster hook action groups to the gluster admin role manipulated ??? Line 17: INSERT INTO roles_groups(role_id,action_group_id) SELECT v_GLUSTER_ADMIN_ROLE_ID, 1004 Line 18: WHERE not exists (SELECT role_id, action_group_id FROM roles_groups Line 19: WHERE role_id=v_GLUSTER_ADMIN_ROLE_ID and action_group_id=1004); Line 20: -- To view, visit http://gerrit.ovirt.org/14831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcab38866c49c6f5d43e3b33006c428ec9304501 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
