Yair Zaslavsky has posted comments on this change.
Change subject: core : Persist AsyncTask before submitting to vdsm
......................................................................
Patch Set 20: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1385: }
Line 1386:
Line 1387: /**
Line 1388: * Create the {@link SPMAsyncTask} object to be run
Line 1389: * @param asyncTaskCreationInfo Info on how to create the task
Please change the doc to add what taskId is.
Line 1390: * @param parentCommand The type of command issuing the task
Line 1391: * @return An {@link SPMAsyncTask} object representing the task
to be run
Line 1392: */
Line 1393: public SPMAsyncTask concreteCreateTask(
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
Line 51: .getStoragePoolId().getValue() : Guid.Empty;
Line 52:
Line 53: VDSReturnValue vdsReturnValue = null;
Line 54: try {
Line 55: Guid taskId =
persistAsyncTaskPlaceHolder(VdcActionType.AddVmFromTemplate);
A repeating question for all child commands - don't we want to to persist the
entity ids besides + the object type ?
Once again , not mandatory.
Line 56:
Line 57: vdsReturnValue = Backend
Line 58: .getInstance()
Line 59: .getResourceManager()
--
To view, visit http://gerrit.ovirt.org/14078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5a548cb53172e6399f4334f24163dd855291ab
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
