Itamar Heim has posted comments on this change.
Change subject: Added the common libraries for the hooks to use
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File hooks/lib/bz.sh
Line 36: else
Line 37: local cookie_jar="$(conf.t_get bz_cookie_jar)"
Line 38: [[ -f ${cookie_jar?You have to login to bugzilla first, see
bz.login} ]]
Line 39: bug_cache="/tmp/bz_cache.$PPID.${bug_id}.${btype}"
Line 40: wget -qO - \
really, no python based sdk for bugzilla?
Line 41: --load-cookies "$cookie_jar" \
Line 42: --save-cookies "$cookie_jar" \
Line 43:
"https://bugzilla.redhat.com/show_bug.cgi?id=${bug_id}${options}"; \
Line 44: | tee "$bug_cache"
Line 160: # Use that url instead of the default one
(https://bugzilla.redhat.com)
Line 161: #
Line 162: bz.login()
Line 163: {
Line 164: local server_url="https://bugzilla.redhat.com";
that's only if bug-url is bugzilla.redhat.com (i admit i didn't see any other
bug tracking system used, so good enough for now, but may need to be
generalized in the future)
Line 165: local OPTIND bug_id plain_bug
Line 166: while getopts "s:b:" option; do
Line 167: case $option in
Line 168: s) server_url="$OPTARG";;
Line 341: # POST -> MODIFIED
Line 342: #
Line 343: # If it's a revert any source status is allowed
Line 344: #
Line 345: bz.update_status()
I may get to this later, but where do you check you are not touching bugs not
of the oVirt product for modified status?
(post status is ok for other product as well)
Line 346: {
Line 347: bug_id="${1?}"
Line 348: new_status="${2?}"
Line 349: commit_id="${3?}"
....................................................
File hooks/lib/conf.sh
Line 12: #
Line 13: #######
Line 14: # Static configuration
Line 15: #######
Line 16: #
whitespace
Line 17: # Static configurations store those values that will persist after each
Line 18: # execution of the hooks, for example users and passwords.
Line 19: #
Line 20: #
--
To view, visit http://gerrit.ovirt.org/15389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a10060cff5c25e8bd8e2f73654208a90cec70d8
Gerrit-PatchSet: 3
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
