Yaniv Bronhaim has posted comments on this change.
Change subject: core Change HibernateVmCommand to persist all placeholders
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
Line 39: @LockIdNameAttribute
Line 40: @DisableInPrepareMode
Line 41: @NonTransactiveCommandAttribute(forceCompensation = true)
Line 42: public class HibernateVmCommand<T extends HibernateVmParameters>
extends VmOperationCommandBase<T> {
Line 43: protected static final String TASK1_KEY = "SaveImage";
if we hold such keys, it should be placed somewhere that all commands could
use..
But i don't understand how 1 string key leads to only 1 unique taskid... you
could start such command multiply times, and each holds the same string keys..
Line 44: protected static final String TASK2_KEY = "SaveRAMState";
Line 45: private boolean isHibernateVdsProblematic = false;
Line 46: /**
Line 47: * Constructor for command creation when compensation is applied
on startup
--
To view, visit http://gerrit.ovirt.org/15443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d830fb9a4afe943524b06d64e7840436fb6b7e8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
